Skip to content

Update repositories.txt #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

DestinationSPACEInc
Copy link
Contributor

added DS_MCP4018 and DS_PCA9536 libraries to registry

added MCP4018 and PCA9536 libraries to registry
@github-actions github-actions bot added the topic: submission Add library to the list label Feb 27, 2024
Copy link
Contributor

A problem was found with your submission https://github.com/Destination-SPACE/DS_MCP4018_Library

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

A problem was found with your submission https://github.com/Destination-SPACE/DS_PCA9536_Library

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @DestinationSPACEInc
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@DestinationSPACEInc
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/Destination-SPACE/DS_MCP4018_Library:

Linting library in DS_MCP4018_Library
INFO: No header file found matching library name (DS_MCP4018_Library.h). Best practices are for primary header filename 
      to match library name.                                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value DS MCP4018 Library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format  
         (Rule LP010)                                                                                            
WARNING: library.properties name DS MCP4018 Library contains spaces. Although supported, best practices is to not use   
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name DS MCP4018 Library contains "library". This is superfluous.                              
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

Linting sketch in DS_MCP4018_Library/examples/mcp4018test

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 5 WARNINGS

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/Destination-SPACE/DS_PCA9536_Library:

Linting library in DS_PCA9536_Library
INFO: No header file found matching library name (DS_PCA9536_Library.h). Best practices are for primary header filename 
      to match library name.                                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value DS PCA9536 Library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format  
         (Rule LP010)                                                                                            
WARNING: library.properties name DS PCA9536 Library contains spaces. Although supported, best practices is to not use   
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name DS PCA9536 Library contains "library". This is superfluous.                              
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

Linting sketch in DS_PCA9536_Library/examples/pca9536test

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 5 WARNINGS

@github-actions github-actions bot merged commit ce9bc6f into arduino:main Feb 27, 2024
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/Destination-SPACE/DS_MCP4018_Library/
http://downloads.arduino.cc/libraries/logs/github.com/Destination-SPACE/DS_PCA9536_Library/

github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant